DM-46003: Increase minimum exposure time for electrometer in ATCalsys #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
approved these changes
Aug 27, 2024
| @@ -317,13 +317,19 @@ async def _calculate_electrometer_exposure_times( | |||
| * electrometer_time_separation_vs_integration | |||
| ) + electrometer_integration_overhead | |||
| max_exp_time = electrometer_buffer_size * time_sep | |||
| if exptime > max_exp_time: | |||
| electrometer_exptimes.append(max_exp_time) | |||
| if exptime < 1.0: | |||
There was a problem hiding this comment.
can you make this "minimum exposure time" an attribute like the others at the top of the method, e.g. eletrometer_mini_exp_time = 1.0?
| if exptime > max_exp_time: | ||
| electrometer_exptimes.append(max_exp_time) | ||
| if exptime < 1.0: | ||
| elec_exptime = 1.0 |
There was a problem hiding this comment.
replace 1.0 with electrometer_min_exp_time.
| if exptime < 1.0: | ||
| elec_exptime = 1.0 | ||
| self.log.info( | ||
| f"Electrometer exposure time increased from {exptime} to 1 sec." |
There was a problem hiding this comment.
Replace "1 sec" with `{electrometer_min_exp_time} sec".
parfa30
force-pushed
the
tickets/DM-46003
branch
2 times, most recently
from
8055702 to
02073c2
Compare
parfa30
force-pushed
the
tickets/DM-46003
branch
from
02073c2 to
271cf8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
electrometer exposure time must be a minimum of 1 second with Keithley electrometer.