Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DM-41830] Add in get_datalink_result #23

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[DM-41830] Add in get_datalink_result #23

merged 2 commits into from
Dec 12, 2023

Conversation

cbanek
Copy link
Contributor

@cbanek cbanek commented Dec 11, 2023

No description provided.

Copy link
Member

@athornton athornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We ended up with too many slashes after the hostname, which woul confuse pyvo.
This would end up in an unauthorized.

Many ways we can do this, like urljoin, but  I'm just as nervous
about all this parsing going one way or thee others.  Just going
to leave it lay until Frossie wants to do service discovery work.
@cbanek cbanek merged commit 1586ee8 into main Dec 12, 2023
2 checks passed
@cbanek cbanek deleted the tickets/DM-41830 branch December 12, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants