Merge pull request #42 from lsst-sqre/tickets/DM-44278

tickets/DM-44278: create path to logging directory if needed
lsst-sqre · May 9, 2024 · 72f9397 · 72f9397
2 parents 67d807c + 45ac267
commit 72f9397
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,13 @@ Find changes for the upcoming release in the project's [changelog.d directory](h
 
 <!-- scriv-insert-here -->
 
+<a id='changelog-0.5.4'></a>
+## 0.5.4 (2024-05-09)
+
+### Bug fixes
+
+- implement mkdir of logging startup parent correctly
+
 <a id='changelog-0.5.3'></a>
 ## 0.5.3 (2024-05-09)
 

diff --git a/src/lsst/rsp/startup/services/labrunner.py b/src/lsst/rsp/startup/services/labrunner.py
@@ -334,7 +334,7 @@ def _copy_logging_profile(self) -> None:
                 copy = True
         if copy:
             pdir = user_profile.parent
-            if not pdir:
+            if not pdir.is_dir():
                 pdir.mkdir(parents=True)
             user_profile.write_bytes(
                 (TOP_DIR_PATH / "jupyterlab" / "20-logging.py").read_bytes()