DM-48326: Avoid commas in generated auth-url annotation #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `GafaelfawrIngress` requesting ticket delegation with multiple delegated scopes represented that with comma-separated scopes in the value of the `delegate_scope` parameter. The current ingress-nginx doesn't allow any escaped characters, so this causes the `Ingress` resource to be rejected. Instead, repeat the `delegate_scope` query parameter for each value, matching how `scope` is handled, which avoids needing commas.
rra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
GafaelfawrIngressrequesting ticket delegation with multiple delegated scopes represented that with comma-separated scopes in the value of thedelegate_scopeparameter. The current ingress-nginx doesn't allow any escaped characters, so this causes theIngressresource to be rejected. Instead, repeat thedelegate_scopequery parameter for each value, matching howscopeis handled, which avoids needing commas.