DM-48173: Use CountedPaginatedQueryRunner from Safir #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
changed the title
rra
force-pushed
the
tickets/DM-48173
branch
from
6fb89d6 to
cf14c64
Compare
Safir has added a `CountedPaginatedQueryRunner` variation that packages the paginated query results with a count of total entries, so Gafaelfawr can stop rolling its own. Switch to the new Safir code and fix a few type signatures that need additional infomration.
rra
force-pushed
the
tickets/DM-48173
branch
from
cf14c64 to
3b919ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safir has added a
CountedPaginatedQueryRunnervariation that packages the paginated query results with a count of total entries, so Gafaelfawr can stop rolling its own. Switch to the new Safir code and fix a few type signatures that need additional infomration.