DM-43943: Update DMTN-222 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
force-pushed
the
tickets/DM-43943
branch
4 times, most recently
from
b1005ff to
d39d4a9
Compare
czwa
force-pushed
the
tickets/DM-43943
branch
from
d39d4a9 to
3e8ab84
Compare
|
Hi Chris, I've attached a PDF with notes on this technote. Feel free to respond to the comments in any way that is easiest for you. |
czwa
force-pushed
the
tickets/DM-43943
branch
from
70d5d28 to
f7e3ce1
Compare
aferte
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Very nice and useful. A few notes:
- yes figure 1 is useful but could you explicitly add TAXICAB in the flowchart? Also I am not sure the 'proposed calibration' to 'Certify for use' arrow makes sense, because we always want to go through cp_verify.
- Could you add an example of a CALIBRATION collection at the end of page 3 to show the CHAINED and RUN collections.
- The JIRA tickets for calib construction might have a lot of attachments, it might be useful to enforce a name (e.g. construction.sh and verification.sh) for the files that document the process that was used so it is easier to find.
- Typos:
- top of page 6: calibraion -> calibration
- one before last paragraph on page 6: 'can be used to As [...]' => 'can be used. As [...]'
- I would be happy to help work on section 6 at some point as I would like to exercise the full process at some point anyway
Alex-Broughton
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version contains my latest "best practices" and command examples.