Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepl glossaries #1264

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Deepl glossaries #1264

wants to merge 7 commits into from

Conversation

sweidac
Copy link

@sweidac sweidac commented Jan 8, 2025

This implements deepl-glossaries. That feature was requested by #807, but I implemented it different from the suggestion:

/**
 * Encapsulate glossary handling.
 *
 * Glossaries are enabled when the `Config.deeplGlossariesDir` setting is set.
 * Files in that directory (only direct children) that follow the naming scheme "{sourceLanguage}-{targetLanguage}.csv"
 *  are considered sources for the glossaries that are kept on the DeepL-servers.
 *
 * To transmit (create/update is the same here) these files, the user must execute one of
 *  - `Commands.deepl_update_glossaries`
 *  - `Commands.deepl_update_glossary`.
 *
 * After the glossaries have been created, they are automatically applied when translating a matching language-pair with deepl.
 */

This PR incorporates #1261 and hence #1262.

I didn't create tests because

  1. I don't know where to start
  2. The approach wasn't discussed ahead of implementation and might therefore change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant