test: Use mock directly (#1146)

#### Motivation Simplify test
linz · Nov 24, 2024 · 326adaf · 326adaf
1 parent 9b81cd0
commit 326adaf
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/commands/basemaps-github/__test__/create-pr-handler.test.ts b/src/commands/basemaps-github/__test__/create-pr-handler.test.ts
@@ -55,10 +55,7 @@ await it('basemapsCreatePullRequest.handler should handle S3 target', async (t)
   t.mock.method(GithubApi.prototype, 'createBlob', () => {});
   t.mock.method(GithubApi.prototype, 'createCommit', () => {});
   t.mock.method(GithubApi.prototype, 'updateBranch', () => {});
-  let createPullRequestCalled = false;
-  t.mock.method(GithubApi.prototype, 'createPullRequest', () => {
-    createPullRequestCalled = true;
-  });
+  const createPullRequestMock = t.mock.method(GithubApi.prototype, 'createPullRequest', () => {});
   const targetUrlsString = JSON.stringify([targetUrl]);
 
   const result = await basemapsCreatePullRequest.handler({
@@ -72,5 +69,5 @@ await it('basemapsCreatePullRequest.handler should handle S3 target', async (t)
     ticket: 'any ticket',
   });
   assert.equal(result, undefined);
-  assert.ok(createPullRequestCalled);
+  assert.equal(createPullRequestMock.mock.callCount(), 1);
 });