Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/liger fused linear cross entropy function does not support reduction=none #496

Merged
merged 7 commits into from
Dec 28, 2024
Merged

Fix/liger fused linear cross entropy function does not support reduction=none #496

merged 7 commits into from
Dec 28, 2024

Conversation

ryankert01
Copy link
Contributor

@ryankert01 ryankert01 commented Dec 21, 2024 •
edited
Loading

Summary

fix #488

Testing Done

  • Hardware Type: A100-40G-PCIe
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@Tcc0403 Tcc0403 self-requested a review December 21, 2024 14:07
Tcc0403
Tcc0403 previously approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@Tcc0403 Tcc0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tcc0403
Copy link
Collaborator

Tcc0403 commented Dec 28, 2024

All tests passed on my machine.

@Tcc0403 Tcc0403 merged commit 9875488 into linkedin:main Dec 28, 2024
2 of 5 checks passed
@ryankert01 ryankert01 deleted the fix/LigerFusedLinearCrossEntropyFunction-does-not-support-reduction=None branch December 28, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tcc0403 Tcc0403 Tcc0403 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LigerFusedLinearCrossEntropyFunction does not support reduction=None
2 participants
@ryankert01 @Tcc0403