metadata: handle empty trailer_uri for shows #1432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across a show, which has an empty
trailer_uri
. In particular, thetrailer_uri
field on thelibrespot_protocol::metadata::Show
struct wasSome("")
, which led to theSpotifyId::from_uri
parsing to fail.This patch accounts for this possibility. Another option would of course be to just use
String
for that field, to avoid any parsing problems.Example:
previously, doing
Show::get(&session, &id).await
yielded forspotify:show:28sR8OiOq0MMnGEzMJTXSt
:With this, it returns: