Recognise OpenBSD as such #1247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librespot and consumers like spotifyd work fine on at least OpenBSD/amd64 7.4-current; arm64 builds and should work equally well. Other platforms also have binary packages, but are either hard to get by and/or unlikely to be used at this point (with librespot), so stick with most prominent amd64/x86_64 and arm64/aarch64 to keep it simple.
|
Where did you get those updated proto definitions from? |
I put them there... forgot to make this PR a draft as I go along. |
|
Fyi those proto definitions are extracted from official clients. We don't own those definitions and we can't safely add our own stuff to them for that reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
librespot and consumers like spotifyd work fine on at least OpenBSD/amd64 7.4-current; arm64 builds and should work equally well. Other platforms also have binary packages, but are either hard to get by and/or unlikely to be used at this point (with librespot), so stick with most prominent amd64/x86_64 and arm64/aarch64 to keep it simple.