Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the fluent email Rule validation #10112

Draft
wants to merge 7 commits into
base: 11.x
Choose a base branch
from

Conversation

SanderMuller
Copy link

Documentation for laravel/framework#54067

validation.md Outdated Show resolved Hide resolved
validation.md Outdated Show resolved Hide resolved
validation.md Outdated Show resolved Hide resolved
validation.md Show resolved Hide resolved
validation.md Outdated Show resolved Hide resolved
validation.md Outdated Show resolved Hide resolved
validation.md Show resolved Hide resolved
@DanielSpravtsev
Copy link

Would be great to see some use cases/examples for methods

@taylorotwell
Copy link
Member

taylorotwell commented Jan 15, 2025

Yeah, explanation of what "strict" compliance means, or what spoofing means would be great! Please mark as ready for review when the requested changes have been made.

@taylorotwell taylorotwell marked this pull request as draft January 15, 2025 19:56
@shaedrich
Copy link
Contributor

shaedrich commented Jan 15, 2025

Yeah, explanation of what "strict" compliance means, or what spoofing means would be great! Please mark as ready for review when the requested changes have been made.

A good place might be here, where it's already mentioned:

docs/validation.md

Lines 1213 to 1224 in 8c527b5

The example above will apply the `RFCValidation` and `DNSCheckValidation` validations. Here's a full list of validation styles you can apply:
<div class="content-list" markdown="1">
- `rfc`: `RFCValidation`
- `strict`: `NoRFCWarningsValidation`
- `dns`: `DNSCheckValidation`
- `spoof`: `SpoofCheckValidation`
- `filter`: `FilterEmailValidation`
- `filter_unicode`: `FilterEmailValidation::unicode()`
</div>

@@ -1240,6 +1241,8 @@ The `filter` validator, which uses PHP's `filter_var` function, ships with Larav
> [!WARNING]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to link this:

- The `filter` validator, which uses PHP's `filter_var` function, ships with Laravel and was Laravel's default email validation behavior prior to Laravel version 5.8.
+ The `filter` validator, which uses PHP's [`filter_var` function](https://www.php.net/manual/en/filter.constants.php#constant.filter-validate-email), ships with Laravel and was Laravel's default email validation behavior prior to Laravel version 5.8.
 
[!WARNING]

@@ -1240,6 +1241,8 @@ The `filter` validator, which uses PHP's `filter_var` function, ships with Larav
> [!WARNING]
> The `dns` and `spoof` validators require the PHP `intl` extension.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could link this:

Suggested change
> The `dns` and `spoof` validators require the PHP `intl` extension.
> The `dns` and `spoof` validators require the [PHP `intl` extension](https://www.php.net/manual/de/book.intl.php).

@shaedrich
Copy link
Contributor

shaedrich commented Jan 15, 2025

Doesn't have #### Defining Default Email Rules an heading level too high? 🤔

@SanderMuller
Copy link
Author

Would be great to see some use cases/examples for methods

@DanielSpravtsev I've been working on some improvements, could you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants