-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the fluent email Rule validation #10112
base: 11.x
Are you sure you want to change the base?
Conversation
Would be great to see some use cases/examples for methods |
Yeah, explanation of what "strict" compliance means, or what spoofing means would be great! Please mark as ready for review when the requested changes have been made. |
A good place might be here, where it's already mentioned: Lines 1213 to 1224 in 8c527b5
|
@@ -1240,6 +1241,8 @@ The `filter` validator, which uses PHP's `filter_var` function, ships with Larav | |||
> [!WARNING] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to link this:
- The `filter` validator, which uses PHP's `filter_var` function, ships with Laravel and was Laravel's default email validation behavior prior to Laravel version 5.8.
+ The `filter` validator, which uses PHP's [`filter_var` function](https://www.php.net/manual/en/filter.constants.php#constant.filter-validate-email), ships with Laravel and was Laravel's default email validation behavior prior to Laravel version 5.8.
[!WARNING]
@@ -1240,6 +1241,8 @@ The `filter` validator, which uses PHP's `filter_var` function, ships with Larav | |||
> [!WARNING] | |||
> The `dns` and `spoof` validators require the PHP `intl` extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could link this:
> The `dns` and `spoof` validators require the PHP `intl` extension. | |
> The `dns` and `spoof` validators require the [PHP `intl` extension](https://www.php.net/manual/de/book.intl.php). |
Doesn't have |
@DanielSpravtsev I've been working on some improvements, could you have a look? |
Documentation for laravel/framework#54067