-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] pt space pte solver #453
base: main
Are you sure you want to change the base?
Conversation
Some quick comments before I review (after the other MR goes in):
I think that's a good idea. My thinking was to use the existing EOS introspection to figure out what kind of lookup should be used and then avoid any costly iterative inversion steps. But this is an optimization step and we should only pursue it if there's a clear performance need.
I agree. Echoing my previous comment, I'm glad you avoided prematurely optimizing. Let's find the bottlenecks first. |
PR Summary
This is a "working" version of the PT-space PTE solver that @dholladay00 started in MR #422, and this MR should replace that one. This version compiles and runs, although I haven't carefully checked for correctness yet. (It reports it converged at least!)
Important notes:
DensityEnergyFromPressureTemperature
more robust across our EOS models and also add introspection necessary to bound the line search used in the PTE solver.DensityEnergyFromPressureTemperature
to build the Jacobian.Remaining to do:
That said, this is ready for feedback.
PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following:
when='@main'
dependencies are updated to the release version in the package.py