Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmm/document versioning #326

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Jmm/document versioning #326

merged 4 commits into from
Nov 30, 2023

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

When doing the most recent release, I realized this process is a bit manual, and has a few steps that are easy to miss. This process doesn't make things more manual, but it at least documents the process.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur added the documentation Improvements or additions to documentation label Nov 30, 2023
@Yurlungur Yurlungur self-assigned this Nov 30, 2023
@Yurlungur
Copy link
Collaborator Author

Ping @dholladay00 @mauneyc-LANL @jhp-lanl @rbberger this should be a quick review and I only need one pair of eyes

Copy link
Collaborator

@jhp-lanl jhp-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Yurlungur Yurlungur merged commit 37c5b73 into main Nov 30, 2023
4 checks passed
@Yurlungur Yurlungur deleted the jmm/document-versioning branch November 30, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants