-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robustify JWL EOS, using robust divide function for divisions. Added … #298
Conversation
…bounded argument exponential function to robust utils.
I've added asserts in the ctor, @jhp-lanl @Yurlungur could you let me know what the physical bounds on those parameters so that appropriately bounding checks can be added to the ctor. |
…mbinations of infinity do not appear to result in an fpe.
@dholladay00 where is this MR at? Should we merge it? |
We could, I think I did this to reduce FPE's in SAP. Perhaps it's good to do in general. I'm not opposed to merging it. |
It's a pretty small changeset. I think we might as well. |
we should probably create an issue to robusify all analytic EOS's in a similar fashion. |
|
…bounded argument exponential function to robust utils.
PR Summary
Improve the robustness of JWL eos. Better checking to prevent FPE's. Added bounded argument exponentials to prevent under/over flow.
PR Checklist
make format
command after configuring withcmake
.