Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify JWL EOS, using robust divide function for divisions. Added … #298

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

dholladay00
Copy link
Collaborator

@dholladay00 dholladay00 commented Aug 25, 2023

…bounded argument exponential function to robust utils.

PR Summary

Improve the robustness of JWL eos. Better checking to prevent FPE's. Added bounded argument exponentials to prevent under/over flow.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

…bounded argument exponential function to robust utils.
@dholladay00
Copy link
Collaborator Author

I've added asserts in the ctor, @jhp-lanl @Yurlungur could you let me know what the physical bounds on those parameters so that appropriately bounding checks can be added to the ctor.

singularity-eos/eos/eos_jwl.hpp Outdated Show resolved Hide resolved
singularity-eos/eos/eos_jwl.hpp Outdated Show resolved Hide resolved
singularity-eos/eos/eos_jwl.hpp Outdated Show resolved Hide resolved
singularity-eos/eos/eos_jwl.hpp Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator

@dholladay00 where is this MR at? Should we merge it?

@dholladay00
Copy link
Collaborator Author

We could, I think I did this to reduce FPE's in SAP. Perhaps it's good to do in general. I'm not opposed to merging it.

@Yurlungur
Copy link
Collaborator

It's a pretty small changeset. I think we might as well.

@dholladay00
Copy link
Collaborator Author

we should probably create an issue to robusify all analytic EOS's in a similar fashion.

@Yurlungur
Copy link
Collaborator

we should probably create an issue to robusify all analytic EOS's in a similar fashion.

#327

@Yurlungur Yurlungur merged commit 34f2208 into main Nov 30, 2023
4 checks passed
@Yurlungur Yurlungur deleted the dholladay00/robust_JWL branch November 30, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants