refactor: Partially drop anyhow from crate::runtimes:wapc
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create src/runtimes/wapc/errors.rs with needed errors so far. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Change the `crates::runtimes::wapc::errors` module to public, as this new `policyEvaluatorError` consumes and wraps `WapcRuntimeError` in some errors. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
fabriziosestito
approved these changes
Jan 30, 2024
src/runtimes/rego/stack_pre.rs
Outdated
| use crate::policy_evaluator::RegoPolicyExecutionMode; | ||
| use crate::policy_evaluator_builder::EpochDeadlines; | ||
|
|
||
| use super::errors::{RegoRuntimeError, Result}; |
There was a problem hiding this comment.
nit: use crate and avoid super as per code conventions
…hydrate() Signed-off-by: Víctor Cuadrado Juan <[email protected]>
flavio
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #377.
crate::runtimes::wapc.It is still missing
crate::runtimes::wapc::callbackwhich will follow up later. The definition of the callback function type is more complicated, and I wanted to have a full codepath for the errors first.crate::runtimes::rego.I recommend reviewing per commit, yet note that for
protocol_version()there's a stopgap change between commits.Note:
protocol_version()is only consumed by kwctl but not yet by policy-server, opened kubewarden/policy-server#642.Test
CI, integration tests.
Additional Information
Tradeoff
Potential improvement