-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #957 from jvanz/enable-webhooks
Webhook integration tests and clean up MatchCondition validation code
- Loading branch information
Showing
18 changed files
with
1,522 additions
and
944 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,172 @@ | ||
| //go:build testing | ||
|
|
||
| /* | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1 | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| admissionregistrationv1 "k8s.io/api/admissionregistration/v1" | ||
|
|
||
| "github.com/kubewarden/kubewarden-controller/internal/constants" | ||
| ) | ||
|
|
||
| func TestAdmissionPolicyDefault(t *testing.T) { | ||
| policy := admissionPolicyFactory() | ||
| policy := AdmissionPolicy{} | ||
| policy.Default() | ||
|
|
||
| require.Equal(t, constants.DefaultPolicyServer, policy.GetPolicyServer()) | ||
| require.Contains(t, policy.GetFinalizers(), constants.KubewardenFinalizer) | ||
| } | ||
|
|
||
| func TestAdmissionPolicyValidateCreate(t *testing.T) { | ||
| policy := admissionPolicyFactory() | ||
| policy := NewAdmissionPolicyFactory().Build() | ||
| warnings, err := policy.ValidateCreate() | ||
| require.NoError(t, err) | ||
| require.Empty(t, warnings) | ||
| } | ||
|
|
||
| func TestAdmissionPolicyValidateUpdate(t *testing.T) { | ||
| oldPolicy := admissionPolicyFactory() | ||
| newPolicy := admissionPolicyFactory() | ||
| oldPolicy := NewAdmissionPolicyFactory().Build() | ||
| newPolicy := NewAdmissionPolicyFactory().Build() | ||
| warnings, err := newPolicy.ValidateUpdate(oldPolicy) | ||
| require.NoError(t, err) | ||
| require.Empty(t, warnings) | ||
|
|
||
| oldPolicy = NewAdmissionPolicyFactory(). | ||
| WithMode("monitor"). | ||
| Build() | ||
| newPolicy = NewAdmissionPolicyFactory(). | ||
| WithMode("protect"). | ||
| Build() | ||
| warnings, err = newPolicy.ValidateUpdate(oldPolicy) | ||
| require.NoError(t, err) | ||
| require.Empty(t, warnings) | ||
| } | ||
|
|
||
| func TestInvalidAdmissionPolicyValidateUpdate(t *testing.T) { | ||
| oldPolicy := NewAdmissionPolicyFactory(). | ||
| WithPolicyServer("old"). | ||
| Build() | ||
| newPolicy := NewAdmissionPolicyFactory(). | ||
| WithPolicyServer("new"). | ||
| Build() | ||
| warnings, err := newPolicy.ValidateUpdate(oldPolicy) | ||
| require.Error(t, err) | ||
| require.Empty(t, warnings) | ||
|
|
||
| newPolicy = NewAdmissionPolicyFactory(). | ||
| WithPolicyServer("new"). | ||
| WithMode("monitor"). | ||
| Build() | ||
|
|
||
| warnings, err = newPolicy.ValidateUpdate(oldPolicy) | ||
| require.Error(t, err) | ||
| require.Empty(t, warnings) | ||
| } | ||
|
|
||
| func TestAdmissionPolicyValidateUpdateWithInvalidOldPolicy(t *testing.T) { | ||
| oldPolicy := clusterAdmissionPolicyFactory(nil, nil, "", "protect") | ||
| newPolicy := admissionPolicyFactory() | ||
| oldPolicy := NewClusterAdmissionPolicyFactory().Build() | ||
| newPolicy := NewAdmissionPolicyFactory().Build() | ||
| warnings, err := newPolicy.ValidateUpdate(oldPolicy) | ||
| require.Empty(t, warnings) | ||
| require.ErrorContains(t, err, "object is not of type AdmissionPolicy") | ||
| } | ||
|
|
||
| func TestInvalidAdmissionPolicyCreation(t *testing.T) { | ||
| policy := NewAdmissionPolicyFactory(). | ||
| WithPolicyServer(""). | ||
| WithRules([]admissionregistrationv1.RuleWithOperations{ | ||
| {}, | ||
| { | ||
| Operations: []admissionregistrationv1.OperationType{}, | ||
| Rule: admissionregistrationv1.Rule{ | ||
| APIGroups: []string{"*"}, | ||
| APIVersions: []string{"*"}, | ||
| Resources: []string{"*/*"}, | ||
| }}, | ||
| { | ||
| Operations: nil, | ||
| Rule: admissionregistrationv1.Rule{ | ||
| APIGroups: []string{"*"}, | ||
| APIVersions: []string{"*"}, | ||
| Resources: []string{"*/*"}, | ||
| }, | ||
| }, | ||
| { | ||
| Operations: []admissionregistrationv1.OperationType{""}, | ||
| Rule: admissionregistrationv1.Rule{ | ||
| APIGroups: []string{"*"}, | ||
| APIVersions: []string{"*"}, | ||
| Resources: []string{"*/*"}, | ||
| }, | ||
| }, | ||
| { | ||
| Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.OperationAll}, | ||
| Rule: admissionregistrationv1.Rule{ | ||
| APIGroups: []string{"*"}, | ||
| APIVersions: []string{}, | ||
| Resources: []string{"*/*"}, | ||
| }, | ||
| }, | ||
| { | ||
| Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.OperationAll}, | ||
| Rule: admissionregistrationv1.Rule{ | ||
| APIGroups: []string{"*"}, | ||
| APIVersions: []string{"*"}, | ||
| Resources: []string{}, | ||
| }, | ||
| }, | ||
| { | ||
| Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.OperationAll}, | ||
| Rule: admissionregistrationv1.Rule{ | ||
| APIGroups: []string{"*"}, | ||
| APIVersions: []string{""}, | ||
| Resources: []string{"*/*"}, | ||
| }, | ||
| }, | ||
| { | ||
| Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.OperationAll}, | ||
| Rule: admissionregistrationv1.Rule{ | ||
| APIGroups: []string{"*"}, | ||
| APIVersions: []string{"*"}, | ||
| Resources: []string{""}, | ||
| }, | ||
| }, | ||
| { | ||
| Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.OperationAll}, | ||
| Rule: admissionregistrationv1.Rule{ | ||
| APIGroups: []string{""}, | ||
| APIVersions: []string{"v1"}, | ||
| Resources: []string{"", "pods"}, | ||
| }, | ||
| }, | ||
| }). | ||
| WithMatchConditions([]admissionregistrationv1.MatchCondition{ | ||
| { | ||
| Name: "foo", | ||
| Expression: "1 + 1", | ||
| }, | ||
| { | ||
| Name: "foo", | ||
| Expression: "invalid expression", | ||
| }, | ||
| }). | ||
| Build() | ||
| warnings, err := policy.ValidateCreate() | ||
| require.Error(t, err) | ||
| require.Empty(t, warnings) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.