Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm-reset: add notes about more manual cleanup steps #49448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neolit123
Copy link
Member

currently the kubeadm reset command when finished prints the following:


The reset process does not clean CNI configuration. To do so, you must remove /etc/cni/net.d

The reset process does not reset or clean up iptables rules or IPVS tables.
If you wish to reset iptables, you must do so manually by using the "iptables" command.

If your cluster was setup to utilize IPVS, run ipvsadm --clear (or similar)
to reset your system's IPVS tables.

The reset process does not clean your kubeconfig files and you must remove them manually.
Please, check the contents of the $HOME/.kube/config file.

instead of printing that information from the CLI we should keep it document at the website and link to the reset page from the output of the command.

xref

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from jbeda and sftim January 15, 2025 13:54
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jan 15, 2025
@neolit123
Copy link
Member Author

/cc @SataQiu @pacoxu @carlory
/cc @danwinship (for the kubeproxy cleanup part)

Comment on lines 47 to 49
### Network traffic assets cleanup

The `kubeadm reset` command does not clean any iptables, nftables or IPVS assets applied
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing 'traffic assets' to 'traffic rules', despite IPVS using 'tables', afaik.

@neolit123 neolit123 force-pushed the 1.33-add-kubeadm-reset-note-about-kubeproxy-cleanup branch from e0905eb to d0e97a5 Compare January 15, 2025 13:59
Copy link

netlify bot commented Jan 15, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e0905eb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6787bdef495b810009ac5345
😎 Deploy Preview https://deploy-preview-49448--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 15, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 79af26c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6787d0319bac42000821e05d
😎 Deploy Preview https://deploy-preview-49448--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@neolit123 neolit123 force-pushed the 1.33-add-kubeadm-reset-note-about-kubeproxy-cleanup branch from d0e97a5 to 79af26c Compare January 15, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants