Make the video section height on the main page flexible #49443
+9
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Shurupov <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
area/web-development
k8s-ci-robot
added
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the KubeCon links section redesign introduced in #49167. While propagating these recent changes to various localisations, I stumbled upon an issue in #49442. When we have a lot of content in the video block (which includes the KubeCon links section), some links might not fit due to a limited height. Here, you can see a missing (hidden) link to the 5th event in the Portuguese localisation:
To prevent this from happening, this PR gets rid of fixed heights for the video block. With
overflow:hiddenadded, it makes its height flexible. E.g., we'll be able to add even more events with no issue:To keep backward compatibility with the pages using old KubeCon links, the
#video:has(#desktopKCButton)workaround is added to_base.scss.My changes also remove an unnecessary
200px-height video block with no content for the mobile layout — it will just disappear. Let me know if we really need it back for mobiles:P.S. I tested the changes in two browsers (Chrome & Firefox) and various localisations (e.g., those that have already adopted new KubeCon links and those that have not).