[zh] sync style/diagram-guide.md #49434
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/zh
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| ```json | ||
| ```text | ||
| {{</* figure src="/static/images/boxnet.svg" alt="Boxnet figure" class="diagram-large" caption="Figure 14. Boxnet caption" */>}} | ||
| ``` | ||
| --> | ||
| ```json |
There was a problem hiding this comment.
Changing from json (the content is not json I know) to text removes some nice highlighting.
Before:
After:
The en version still uses json though.
There was a problem hiding this comment.
Yes, we can improve the consistency in the context of en version indeed. Some are marked with text, some with json.
| @@ -580,7 +597,7 @@ First, use your external tool to create the diagram and save it as an `.svg` | |||
| or `.png` image file. After that, use the same steps as the __Mermaid+SVG__ | |||
| method for adding `.svg` image files. | |||
| --> | |||
| ### 外部工具 | |||
There was a problem hiding this comment.
Is it necessary to add the english internal link ref? The current works fine for me.
There was a problem hiding this comment.
Yes, it is required to add anchors in the zh version manually for headings 2 and 3, to keep the same anchors as en version.
| @@ -57,11 +56,17 @@ X --> V[提示] | |||
| %% you can hyperlink Mermaid diagram nodes to a URL using click statements | |||
|
|
|||
| click A "https://mermaid-js.github.io/mermaid-live-editor/edit/#eyJjb2RlIjoiZmxvd2NoYXJ0IExSXG4gICAgc3ViZ3JhcGggbVtNZXJtYWlkLmpzXVxuICAgIGRpcmVjdGlvbiBUQlxuICAgICAgICBTWyBdLS4tXG4gICAgICAgIENbYnVpbGQ8YnI-ZGlhZ3JhbXM8YnI-d2l0aCBtYXJrZG93bl0gLS0-XG4gICAgICAgIERbb24tbGluZTxicj5saXZlIGVkaXRvcl1cbiAgICBlbmRcbiAgICBBW1doeSBhcmUgZGlhZ3JhbXM8YnI-dXNlZnVsP10gLS0-IG1cbiAgICBtIC0tPiBOWzMgeCBtZXRob2RzPGJyPmZvciBjcmVhdGluZzxicj5kaWFncmFtc11cbiAgICBOIC0tPiBUW0V4YW1wbGVzXVxuICAgIFQgLS0-IFhbU3R5bGluZzxicj5hbmQ8YnI-Y2FwdGlvbnNdXG4gICAgWCAtLT4gVltUaXBzXVxuICAgIFxuIFxuICAgIGNsYXNzRGVmIGJveCBmaWxsOiNmZmYsc3Ryb2tlOiMwMDAsc3Ryb2tlLXdpZHRoOjFweCxjb2xvcjojMDAwO1xuICAgIGNsYXNzRGVmIHNwYWNld2hpdGUgZmlsbDojZmZmZmZmLHN0cm9rZTojZmZmLHN0cm9rZS13aWR0aDowcHgsY29sb3I6IzAwMFxuICAgIGNsYXNzIEEsQyxELE4sWCxtLFQsViBib3hcbiAgICBjbGFzcyBTIHNwYWNld2hpdGUiLCJtZXJtYWlkIjoie1xuICBcInRoZW1lXCI6IFwiZGVmYXVsdFwiXG59IiwidXBkYXRlRWRpdG9yIjpmYWxzZSwiYXV0b1N5bmMiOnRydWUsInVwZGF0ZURpYWdyYW0iOnRydWV9" _blank | |||
|
|
|||
There was a problem hiding this comment.
Is adding the line breaks necessary? Since the en docs don't have line breaks.
There was a problem hiding this comment.
The en doc is required to improve for this kind of consistency in context. Some have blank lines, some not.
There was a problem hiding this comment.
Yeah, I noticed that
has line breaks. Well, its a nitpick and wanted to know if there was some other reason.
|
Thanks for the PR. It should close #49431. I have done a review which is a bit nitpicky but the reasoning behind those changes will help in understanding if similar changes are required for other translations too. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chalin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update zh content in:
See preview