Fixed link navigation bug #49414
Fixed link navigation bug #49414
Conversation
Signed-off-by: aakankshabhende <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -434,7 +434,7 @@ The above scenario can be replicated by using a [Sidecar Container](/docs/concep | |||
| as a helper container to write the HTML file. | |||
| As a Sidecar Container is conceptually an Init Container, it is guaranteed to start before the main web server container. | |||
| This ensures that the HTML file is always available when the web server is ready to serve it. | |||
| Please see [Enabling sidecar containers](/docs/concepts/workloads/pods/sidecar-containers/#enabling-sidecar-containers) to utilize this feature. | |||
| Please see [Enabling sidecar containers](/docs/concepts/workloads/pods/sidecar-containers/#sidecar-example) to utilize this feature. | |||
There was a problem hiding this comment.
Instead of linking to the example section, perhaps we could update the link text to point directly to the previous section? This might make it a bit better.
| Please see [Enabling sidecar containers](/docs/concepts/workloads/pods/sidecar-containers/#sidecar-example) to utilize this feature. | |
| Please see [Sidecar containers in Kubernetes](/docs/concepts/workloads/pods/sidecar-containers/#pod-sidecar-containers) to utilize this feature. |
There was a problem hiding this comment.
Actually the first line of section points to /docs/concepts/workloads/pods/sidecar-containers/ which explains what is sidecar container, I thought it would get redundant if we point to the same section again.
There was a problem hiding this comment.
I meant the line 433 which explains what is sidecar container. What do you suggest? @dipesh-rawat
Description
The subsection "Update configuration via a ConfigMap in a Pod possessing a sidecar container" contains the sentence:
The sidecar-containers page doesn't have a subsection on enabling sidecar containers, so I navigated the link to example showing deployment having sidecar config.
Issue
Closes: #49326