Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tencent Cloud in cloud provider security #49411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Tencent Cloud in cloud provider security #49411

wants to merge 1 commit into from

Conversation

astraw99
Copy link
Member

Description

Add IaaS Provider Tencent Cloud in cloud provider security, ordered by the alphabetical order.

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a0f9c95
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6785f07e55d49f0008478893
😎 Deploy Preview https://deploy-preview-49411--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jan 13, 2025

/retitle Add Tencent Cloud in cloud provider security

@k8s-ci-robot k8s-ci-robot changed the title Add Tencent Cloud in cloud provider security Add Tencent Cloud in cloud provider security Jan 13, 2025
sftim
sftim reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a link to a product, not documentation about how to use a cloud provider securely (or why that provider can be trusted). @astraw99 that's not the same as the other items in the list.

/hold

We should not merge this. OK to unhold if an approver determines that the PR has changed since I filed this concern.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
@astraw99
Copy link
Member Author

@sftim Got it, link updated. PTAL thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@Princesso Princesso Awaiting requested review from Princesso

@reylejano reylejano Awaiting requested review from reylejano

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astraw99 @k8s-ci-robot @sftim