-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit kubect set file #49392
base: main
Are you sure you want to change the base?
Edit kubect set file #49392
Conversation
Modify the example 'Set the labels and selector before creating a deployment/service pair' because the original example did not include the --image flag when creating the deployment
Update kubectl_set_selector.md
Add a new example: 'Set resource requests while creating a deployment,' which is more efficient.
Update kubectl_set_resources.md
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @wqtb! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/easycla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kubectl set resources reference page is auto-generated, so this fix might need to be applied elsewhere (either in the generator code or the API definition that the generator uses as its input).
Here are some useful links for additional guidance:
-
For guidance on Updating Reference Documentation, check out: https://kubernetes.io/docs/contribute/generate-ref-docs/
-
To generate reference docs and contribute upstream, check out: kubernetes.io/docs/contribute/generate-ref-docs/contribute-upstream
-
For generating reference documentation for kubectl commands, refer to: https://kubernetes.io/docs/contribute/generate-ref-docs/kubectl/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even this kubectl set selector reference page is auto-generated, it would be more effective to regenerate the reference documentation incorporating upstream fixes.
Update kubectl_set_selector to fix the mistake in the example and add a new example to kubectl_set_resources