Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit kubect set file #49392

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Edit kubect set file #49392

wants to merge 4 commits into from

Conversation

wqtb
Copy link

@wqtb wqtb commented Jan 11, 2025

Update kubectl_set_selector to fix the mistake in the example and add a new example to kubectl_set_resources

wqtb added 4 commits January 11, 2025 21:53
Modify the example 'Set the labels and selector before creating a deployment/service pair' because the original example did not include the --image flag when creating the deployment
Update kubectl_set_selector.md
Add a new example: 'Set resource requests while creating a deployment,' which is more efficient.
Update kubectl_set_resources.md
Copy link

linux-foundation-easycla bot commented Jan 11, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 11, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 11, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @wqtb!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2025
Copy link

netlify bot commented Jan 11, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 40f7c72
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67827c3e1f70ed0008f72c62
😎 Deploy Preview https://deploy-preview-49392--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 11, 2025
@wqtb
Copy link
Author

wqtb commented Jan 11, 2025

/easycla

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kubectl set resources reference page is auto-generated, so this fix might need to be applied elsewhere (either in the generator code or the API definition that the generator uses as its input).

Here are some useful links for additional guidance:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even this kubectl set selector reference page is auto-generated, it would be more effective to regenerate the reference documentation incorporating upstream fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants