Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

structured-merge-diff: update OWNERS file #34138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

structured-merge-diff: update OWNERS file #34138

wants to merge 1 commit into from

Conversation

yongruilin
Copy link

Move lavalamp@ and jennybuckley@ to emeritus.
Add jpetz@ to reviewers and approvers

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yongruilin
Once this PR has been reviewed and has the lgtm label, please assign apelisse for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 13, 2025
@yongruilin
Copy link
Author

/cc @BenTheElder
/cc @jpbetz

BenTheElder
BenTheElder reviewed Jan 13, 2025
View reviewed changes
config/jobs/kubernetes-sigs/structured-merge-diff/OWNERS Outdated
approvers:
- lavalamp
- apelisse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is @apelisse active? if not, we should also emeritus and we should add someone other than joe (yourself?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like he's not active for over a year. Updated.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2025
jpbetz
jpbetz reviewed Jan 14, 2025
View reviewed changes
config/jobs/kubernetes-sigs/structured-merge-diff/OWNERS Outdated
approvers:
- lavalamp
- jpbetz
- yongruilin
Copy link
Contributor

@jpbetz jpbetz Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to have another approver besides myself here. But our process has been to someone to reviewers first, and after they've demonstrated they have a commanding understanding of the code through their reviews, propose adding them to approvers. I'm willing to accelerate that here, but I do think we should wait before adding to approvers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG. I've removed myself.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2025
@yongruilin
structured-merge-diff: update OWNERS file
b598c65 
Move lavalamp@ and jennybuckley@ to emeritus.
Add jpbetz@ to reviewers and approvers
Add yongruilin@ to reviewers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@jpbetz jpbetz jpbetz left review comments

@apelisse apelisse Awaiting requested review from apelisse

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yongruilin @k8s-ci-robot @jpbetz @BenTheElder