-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
structured-merge-diff: Add presubmit job for structured merge diff API diff #34135
base: master
Are you sure you want to change the base?
Conversation
/cc @jpbetz Also, could we update the OWNERS file? I think lavalamp@ and jennybuckley@ should be moved to |
please do! send a PR, thanks! |
resources: | ||
limits: | ||
cpu: 2 | ||
memory: 4Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can be less conservative with memory, I believe we have 8 core x 64gi hosts so ~~8 per vcpu (ignoring kubelet etc using some of both). We're rarely memory bound scheduling and tasks completing quicker (with more cache etc) is actually cheaper.
(on GCP we use n1-highmem-8 https://github.com/kubernetes/k8s.io/blob/86089ae44dd87d86fa1a2a651bb0d6f4ceb06270/infra/gcp/terraform/k8s-infra-prow-build/main.tf#L101)
I filed an issue to track documenting this better: #34139
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I put it 16Gi
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, yongruilin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref: kubernetes-sigs/structured-merge-diff#276