Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-3041]: drop Nodefeature from test-infra #33931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[KEP-3041]: drop Nodefeature from test-infra #33931

wants to merge 1 commit into from
+100 −100

Conversation

kannon92
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 11, 2024
@kannon92 kannon92 mentioned this pull request Dec 11, 2024
Open
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024
@kannon92 kannon92 force-pushed the remove-node-feature branch from 688f0a4 to 10e5830 Compare December 18, 2024 23:15
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 18, 2024
@kannon92 kannon92 force-pushed the remove-node-feature branch from 10e5830 to 8c57177 Compare December 23, 2024 17:21
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2025
@kannon92 kannon92 force-pushed the remove-node-feature branch from 8c57177 to 058de79 Compare January 15, 2025 16:09
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025
@kannon92
Copy link
Contributor Author

/hold cancel

Testgrid looks good from deprecation so this is next on my list to merge.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
SergeyKanzhelev
SergeyKanzhelev approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92, SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please assign mrhohn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kannon92
Copy link
Contributor Author

@dims @aojea

Could you help with the network related approvals for this?

We merged a PR that replicates NodeFeature and Feature. I want to drop the use of NodeFeature and replace it with Feature.

I have approval from sig-node side and just have some items for network.

@dims
Copy link
Member

dims commented Jan 15, 2025

@kannon92 will let @aojea first crack at this, ping me back on say friday?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@bowei bowei Awaiting requested review from bowei

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: PRs - Needs Approver
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kannon92 @k8s-ci-robot @dims @SergeyKanzhelev