allows for image repos to be set via Environment Variables

[rackeric]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Sometimes clusters will not have access to upstream image repos. This updates the manifests in the clusterloader2 "load" test to support setting the 2 image repos used via Environment Variables, like the others starting with '.CL', while still keeping the current repos set as defaults. This allows the use of mirrors image repos which may be available to clusters.

.CL2_REGISTRY_K8S_REPO for registry.k8s.io
.CL2_GCR_REPO for gcr.io

Which issue(s) this PR fixes:

Fixes # #2704

Special notes for your reviewer:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rackeric / name: Eric Hernandez (9d1d071)

[k8s-ci-robot]

Welcome @rackeric!

It looks like this is your first PR to kubernetes/perf-tests 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/perf-tests has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rackeric. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[vincepri]

/ok-to-test

[vincepri]

Suggested change

	{{$registryK8sRepo := DefaultParam .CL2_REGISTRY_K8S_REPO "registry.k8s.io"}}
	{{$imageRegistry := DefaultParam .CL2_REGISTRY_K8S_REPO "registry.k8s.io"}}

[rackeric]

I gave this a more descriptive name, registryK8sRepo, since there are 2 image registries used and I thought it would help highlight which repo exactly was being specified.

[vincepri]

This field and above seem different registries for different images, I'll defer to this repository's maintainers here, but maybe we should try to find some naming that clarifies a bit more where they're set?

[rackeric]

Same, I'll take any suggestion made from the code owners.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rackeric
Once this PR has been reviewed and has the lgtm label, please assign wojtek-t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• clusterloader2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rackeric]

/retest

[rackeric]

/retest

[rackeric]

/retest

[rackeric]

/retest

[rackeric]

/retest

[rackeric]

/retest

[k8s-ci-robot]

@rackeric: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-perf-tests-clusterloader2	9d1d071	link	true	/test pull-perf-tests-clusterloader2
pull-perf-tests-clusterloader2-kubemark	9d1d071	link	true	/test pull-perf-tests-clusterloader2-kubemark

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.