make sure use correct endpoint for China cluster

[neda1985]

My boyfriend was working with Kops and ran into an issue where the URI generator wasn’t behaving as expected in the China cluster. Turns out, the problem was with the endpoint (used for setting up IRSA) in China—it had an extra .cn at the end of the string. After digging into it, I found the fix! 😎
For reference: AWS China Endpoints Documentation

[linux-foundation-easycla]

• ✅login: neda1985 / (7e73809)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @neda1985!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @neda1985. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hakman]

/ok-to-test

[hakman]

Hi @neda1985, thank you for doing this PR and for flagging the issue. @rifelpet found a more generic way to handle endpoints, including China. Please take a look at #17183.

[neda1985]

Hi @neda1985, thank you for doing this PR and for flagging the issue. @rifelpet found a more generic way to handle endpoints, including China. Please take a look at #17183.

No problem, i would be more than happy. to contribute, so I need to wait till #17183 get merged ?

[hakman]

Hi @neda1985, thank you for doing this PR and for flagging the issue. @rifelpet found a more generic way to handle endpoints, including China. Please take a look at #17183.

No problem, i would be more than happy. to contribute, so I need to wait till #17183 get merged ?

Awesome, thank you. The PR has been merged. Please build from master and give it a try when you get a chance.
Also, if you notice more issues and you want to contribute, you are more than welcome to do it! 🙂

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[neda1985]

Hi @neda1985, thank you for doing this PR and for flagging the issue. @rifelpet found a more generic way to handle endpoints, including China. Please take a look at #17183.

No problem, i would be more than happy. to contribute, so I need to wait till #17183 get merged ?

Awesome, thank you. The PR has been merged. Please build from master and give it a try when you get a chance. Also, if you notice more issues and you want to contribute, you are more than welcome to do it! 🙂

cool😁, what about the old versions? should we expect fix for 1.28 and 1.29 ?

[hakman]

Hi @neda1985, thank you for doing this PR and for flagging the issue. @rifelpet found a more generic way to handle endpoints, including China. Please take a look at #17183.

No problem, i would be more than happy. to contribute, so I need to wait till #17183 get merged ?

Awesome, thank you. The PR has been merged. Please build from master and give it a try when you get a chance. Also, if you notice more issues and you want to contribute, you are more than welcome to do it! 🙂

cool😁, what about the old versions? should we expect fix for 1.28 and 1.29 ?

I think kOps 1.28 and 1.29 use github.com/aws/aws-sdk-go instead of github.com/aws/aws-sdk-go-v2 and not sure if the fix is relevant there. Can you check if a fix needed for 1.29?

[k8s-ci-robot]

@neda1985: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kops-e2e-gce-cni-calico	7e73809	link	true	/test pull-kops-e2e-gce-cni-calico
pull-kops-e2e-gce-cni-cilium	7e73809	link	true	/test pull-kops-e2e-gce-cni-cilium
pull-kops-e2e-gce-cni-kindnet	7e73809	link	true	/test pull-kops-e2e-gce-cni-kindnet

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.