Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4817: Add beta graduation criteria + implementation history #5043

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-4817: Add beta graduation criteria + implementation history #5043

wants to merge 1 commit into from
+4 −0

Conversation

LionelJouin
Copy link
Member

  • One-line PR description: Add beta graduation criteria + implementation history
  • Other comments: KEP-4817

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LionelJouin
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2025
aojea
aojea reviewed Jan 15, 2025
View reviewed changes
keps/sig-node/4817-resource-claim-device-status/README.md
Comment on lines +441 to +442
- The kubernetes-sigs/cni-dra-driver project as reference implementation for this feature.
- A new EndpointSlice Controller consuming the `ResourceClaim.Status.Devices[].NetworkData.Addresses` field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just it is important to mention that we need automated e2e test running periodically in beta, to take into consideration is not just to merge the code, is to make sure it is working and tested.
I'll be helping with that but I can not own it, I already maintain all the other testing ... so I expect the multi network community to own this CI , is that fair?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean automated e2e tests running periodically for the cni-dra-driver and this new EndpointSlice Controller? I think that is fair yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LionelJouin @k8s-ci-robot @aojea