Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4330: update minCompatibilityVersion range. #5006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-4330: update minCompatibilityVersion range. #5006

wants to merge 1 commit into from

Conversation

siyuanfoundation
Copy link
Contributor

  • One-line PR description:
    update minCompatibilityVersion range to make it more consistent and clear.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
@siyuanfoundation
Copy link
Contributor Author

/cc @jpbetz @Jefftree @aaron-prindle

@jpbetz
Copy link
Contributor

jpbetz commented Dec 18, 2024

/approve
/lgtm

Thanks for cleaning this up

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@aaron-prindle
Copy link

aaron-prindle commented Dec 18, 2024 •
edited
Loading

/lgtm

Thanks for the cleanup here!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpbetz, siyuanfoundation
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@siyuanfoundation
Copy link
Contributor Author

/cc @derekwaynecarr for sig approval

@k8s-ci-robot
Copy link
Contributor

@siyuanfoundation: GitHub didn't allow me to request PR reviews from the following users: for, sig, approval.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @derekwaynecarr for sig approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@siyuanfoundation siyuanfoundation changed the title update minCompatibilityVersion range. KEP-4330: update minCompatibilityVersion range. Jan 14, 2025
@Jefftree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@siyuanfoundation siyuanfoundation mentioned this pull request Jan 14, 2025
Open
Jefftree
Jefftree reviewed Jan 15, 2025
View reviewed changes
keps/sig-architecture/4330-compatibility-versions/README.md
version N must be (en/de)codable for k8s versions N-1 through N+1.
To enable upgrades and rollbacks, pre compatibility version, the version selected for storage in etcd in
version N must be (en/de)codable for k8s versions N-1 through N+1. With compatibility version, the version selected for storage in etcd in
compatibility version `EmulationVersion+MinCompatibilityVersion` must be (en/de)codable for k8s versions `MinCompatibilityVersion` through `EmulationVersion+1`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Usage of the + sign is a bit weird here, could imply addition of the versions. Maybe split into two words?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefftree Jefftree Jefftree left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@jpbetz jpbetz

@aaron-prindle aaron-prindle

@Jefftree Jefftree

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siyuanfoundation @jpbetz @aaron-prindle @k8s-ci-robot @Jefftree