Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: Update v1.10 release team members #8241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CAPI: Update v1.10 release team members #8241

wants to merge 1 commit into from
+22 −10

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Jan 9, 2025

This PR syncs up the Slack cluster-api-release-team with its current v1.10-release members.

Which issue(s) this PR fixes:

Refs kubernetes-sigs/cluster-api#11648

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jeefy January 9, 2025 19:15
@k8s-ci-robot k8s-ci-robot added area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2025
@mboersma mboersma mentioned this pull request Jan 9, 2025
Open
38 tasks
@cahillsf
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
@mboersma
Copy link
Contributor Author

/assign @coderanger

chandankumar4
chandankumar4 approved these changes Jan 13, 2025
View reviewed changes
Copy link

@chandankumar4 chandankumar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mrbobbytables
mrbobbytables requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The slack config unfortunately won't work with just usernames, because slack allows for collisions 🙃
We have to add a mapping of userIDs to handles here: https://github.com/kubernetes/community/blob/master/communication/slack-config/users.yaml

and then they can be referenced in this file or elsewhere.

@mrbobbytables
Copy link
Member

/hold
just till the userID mappings are added 👍

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
@mboersma mboersma force-pushed the sync-capi-release-team branch from 60c4d7c to 482b774 Compare January 13, 2025 20:19
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
@mboersma
Copy link
Contributor Author

/hold cancel

I added the userid mappings for new team members. Thanks for the clue @mrbobbytables!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
cprivitere
cprivitere approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@cprivitere cprivitere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chandankumar4, cprivitere, mboersma
Once this PR has been reviewed and has the lgtm label, please ask for approval from coderanger. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables mrbobbytables requested changes

@chandankumar4 chandankumar4 chandankumar4 approved these changes

@cprivitere cprivitere cprivitere approved these changes

@jeefy jeefy Awaiting requested review from jeefy

Assignees

@coderanger coderanger

@cprivitere cprivitere

@cahillsf cahillsf

Labels
area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mboersma @cahillsf @mrbobbytables @k8s-ci-robot @cprivitere @chandankumar4 @coderanger