-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete deletion of CnsFileAccessConfig instance if associated nodeVM instance is not found #3151
base: master
Are you sure you want to change the base?
Complete deletion of CnsFileAccessConfig instance if associated nodeVM instance is not found #3151
Conversation
…M instance is not found
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vdkotkar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @vdkotkar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
backOffDurationMapMutex.Lock() | ||
delete(backOffDuration, instance.Name) | ||
backOffDurationMapMutex.Unlock() | ||
return reconcile.Result{}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we return success here, we will miss the deletePermission on the fileshare.
I think we need to invoke
"err = r.configureNetPermissionsForFileVolume(ctx, volumeID, vm, instance, true)".
I'm not sure how you can fetch the vm info though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, since VM is already deleted we won't get VM object. So, it is not possible to run configureNerPermissionsForFileVolume. I am also not sure if we can do anything else here.
@divyenpatel Can you please review these changes once.
What this PR does / why we need it:
If nodeVM instance is deleted and later we get request to delete CnsFileAccessConfig instance, then currently we return error and cnsfileaccessconfig instance never gets deleted.
Updating code to proceed with the deletion of cnsfileaccessconfig instance if the associated nodeVM instance is not found (already deleted).
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done:
make check
andmake test
are passing.Special notes for your reviewer:
Release note: