Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #3908 and #3923: Fix the requirement for VAP #3977

Open
wants to merge 1 commit into
base: release-0.9
Choose a base branch
from

Conversation

varshaprasad96
Copy link
Member

What type of PR is this?

Cherry-pick: #3908

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: varshaprasad96
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshaprasad96 varshaprasad96 changed the title Cherry-pick: Fix the requirement for VAP Cherry-pick #3908: Fix the requirement for VAP Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 15, 2025
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 123a4ee
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6787f442e302de000833f3ce

@mimowo
Copy link
Contributor

mimowo commented Jan 15, 2025

It looks suspiciously many files updated compared to the original fix. Can you double check

Signed-off-by: Varsha Prasad Narsing <[email protected]>
@varshaprasad96
Copy link
Member Author

@mimowo This is a cherry pick of #3908 and #3923. Since there are additional plugins defined here in the disablePlugins slice, those packages are being vendored.

@varshaprasad96 varshaprasad96 changed the title Cherry-pick #3908: Fix the requirement for VAP Cherry-pick #3908 and #3923: Fix the requirement for VAP Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

@varshaprasad96: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-verify-release-0-9 123a4ee link true /test pull-kueue-verify-release-0-9

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants