Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Delete workers' workloads if MK AC is rejected #3938

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] Delete workers' workloads if MK AC is rejected #3938

wants to merge 1 commit into from
+113 −0

Conversation

mszadkow
Copy link
Contributor

@mszadkow mszadkow commented Jan 7, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3841

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 345461e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6787d086627e2c0008182238

@mszadkow
Copy link
Contributor Author

mszadkow commented Jan 7, 2025

/test pull-kueue-test-integration-main

@mszadkow
Copy link
Contributor Author

mszadkow commented Jan 7, 2025

@mimowo do you think it's valid test case for this behaviour?

@mszadkow mszadkow force-pushed the fix/wl-removed-if-mk-ac-rejected branch from b7656ca to a7a9ccb Compare January 7, 2025 16:29
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2025
@mszadkow
Copy link
Contributor Author

mszadkow commented Jan 7, 2025

/test pull-kueue-test-integration-main

@mszadkow mszadkow force-pushed the fix/wl-removed-if-mk-ac-rejected branch 2 times, most recently from 12da653 to 6c216dc Compare January 10, 2025 13:41
@mszadkow
Copy link
Contributor Author

/test pull-kueue-test-integration-main

@mszadkow mszadkow marked this pull request as ready for review January 10, 2025 20:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2025
mimowo
mimowo reviewed Jan 14, 2025
View reviewed changes
test/integration/multikueue/multikueue_test.go
g.Expect(managerTestCluster.client.Get(managerTestCluster.ctx, wlLookupKey, createdWorkload)).To(gomega.Succeed())
acs := workload.FindAdmissionCheck(createdWorkload.Status.AdmissionChecks, multikueueAC.Name)
g.Expect(acs).NotTo(gomega.BeNil())
g.Expect(acs.State).To(gomega.Equal(kueue.CheckStatePending))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you describe why the AC is Pending in the first case, but Ready in the other? It is not that clear, why it is Pending here, maybe this is only for a brief period? In that case I'm concerned it could flake. I think we can just start with the second It in that case, as this is the scenario I was thinking about when opening the issue.

@mszadkow mszadkow force-pushed the fix/wl-removed-if-mk-ac-rejected branch from 6c216dc to 345461e Compare January 15, 2025 15:13
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mszadkow
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

@PBundyra PBundyra Awaiting requested review from PBundyra

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiKueue should remove workloads on workers if the MK admission check gets rejected
3 participants
@mszadkow @k8s-ci-robot @mimowo