Skip to content

Commit

Permalink
review comment: log error and add TODO with issue link
Browse files Browse the repository at this point in the history
  • Loading branch information
dgrove-oss committed Jan 13, 2025
1 parent 25f12bd commit 88bb3a2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/controller/jobs/appwrapper/appwrapper_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"

kueue "sigs.k8s.io/kueue/apis/kueue/v1beta1"
Expand Down Expand Up @@ -116,7 +117,9 @@ func (aw *AppWrapper) GVK() schema.GroupVersionKind {
func (aw *AppWrapper) PodSets() []kueue.PodSet {
podSets, err := awutils.GetPodSets((*awv1beta2.AppWrapper)(aw))
if err != nil {
// TODO: https://github.com/kubernetes-sigs/kueue/issues/3969
// Kueue will raise an error on zero length PodSet; the Kueue GenericJob API prevents propagating the actual error.
ctrl.Log.Error(err, "Error returned from awutils.GetPodSets", "appwrapper", aw)
return []kueue.PodSet{}
}
return podSets
Expand Down

0 comments on commit 88bb3a2

Please sign in to comment.