Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI test from AlmaLinux8 to AlmaLinux9 #11889

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

yankay
Copy link
Member

@yankay yankay commented Jan 14, 2025

What type of PR is this?

/kind flake

What this PR does / why we need it:

Kubernetes needs a higher kernel version.
Update CI test from AlmaLinux8 to AlmaLinux9, and keep a few of the AlmaLinux8

Which issue(s) this PR fixes:

Fixes #11888

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update CI test from AlmaLinux8 to AlmaLinux9

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2025
@yankay yankay force-pushed the update-AlmaLinux-9 branch from 43e646c to d980985 Compare January 14, 2025 06:29
@tico88612
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 14, 2025
Comment on lines +151 to 155
packet_almalinux9-calico:
extends: .packet_pr_extended

packet_almalinux8-docker:
packet_almalinux9-docker:
extends: .packet_pr_extended
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the label ci-extend to this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Idea

@yankay yankay added the ci-extended Run additional tests label Jan 14, 2025
@yankay
Copy link
Member Author

yankay commented Jan 14, 2025

HI @VannTen @mzaian
Would you please help to review the PR :-)

@tico88612
Copy link
Member

/retest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this one supposed to be a rename instead ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packet_almalinux8-calico.yml is for the CI test of

The packet_almalinux8-calico.yml is currently the only test for AlmaLinux 8, and it serves a purpose as we transition to AlmaLinux 9. (ref in https://github.com/kubernetes-sigs/kubespray/pull/11889/files#diff-206b454affafdea51d307ede4e68fcb65fe63d371dc9e50f9a8718fa58bb85ffR106)

However, if we decide to deprecate support for the RedHat 8 family, as discussed in #11872 , this test will need to be removed. For now, it remains relevant to catch any issues before fully moving on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, works for me then 👍

@@ -6,7 +6,8 @@ To generate this Matrix run `./tests/scripts/md-table/main.py`

| OS / CNI | calico | cilium | custom_cni | flannel | kube-ovn | kube-router | macvlan |
|---| --- | --- | --- | --- | --- | --- | --- |
almalinux8 | :white_check_mark: | :x: | :x: | :x: | :white_check_mark: | :x: | :x: |
almalinux8 | :white_check_mark: | :x: | :x: | :x: | :x: | :x: | :x: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line should be removed by pre-commit if we don't have any test with almalinux 8, right ? Or did you leave one on purpose maybe ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave this one on purpose :-)

@@ -26,6 +26,7 @@ SUPPORTED_OS = {
"centos8-bento" => {box: "bento/centos-8", user: "vagrant"},
"almalinux8" => {box: "almalinux/8", user: "vagrant"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we replace alma8 completely, wdyt ?

@VannTen
Copy link
Contributor

VannTen commented Jan 14, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3527cb1 into kubernetes-sigs:master Jan 14, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ci-extended Run additional tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI test from AlmaLinux8 to AlmaLinux9
4 participants