-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI test from AlmaLinux8 to AlmaLinux9 #11889
Update CI test from AlmaLinux8 to AlmaLinux9 #11889
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Kay Yan <[email protected]>
43e646c
to
d980985
Compare
/kind feature |
packet_almalinux9-calico: | ||
extends: .packet_pr_extended | ||
|
||
packet_almalinux8-docker: | ||
packet_almalinux9-docker: | ||
extends: .packet_pr_extended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the label ci-extend
to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Idea
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this one supposed to be a rename instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packet_almalinux8-calico.yml
is for the CI test of
The packet_almalinux8-calico.yml
is currently the only test for AlmaLinux 8, and it serves a purpose as we transition to AlmaLinux 9. (ref in https://github.com/kubernetes-sigs/kubespray/pull/11889/files#diff-206b454affafdea51d307ede4e68fcb65fe63d371dc9e50f9a8718fa58bb85ffR106)
However, if we decide to deprecate support for the RedHat 8 family, as discussed in #11872 , this test will need to be removed. For now, it remains relevant to catch any issues before fully moving on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, works for me then 👍
@@ -6,7 +6,8 @@ To generate this Matrix run `./tests/scripts/md-table/main.py` | |||
|
|||
| OS / CNI | calico | cilium | custom_cni | flannel | kube-ovn | kube-router | macvlan | | |||
|---| --- | --- | --- | --- | --- | --- | --- | | |||
almalinux8 | :white_check_mark: | :x: | :x: | :x: | :white_check_mark: | :x: | :x: | | |||
almalinux8 | :white_check_mark: | :x: | :x: | :x: | :x: | :x: | :x: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That line should be removed by pre-commit if we don't have any test with almalinux 8, right ? Or did you leave one on purpose maybe ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave this one on purpose :-)
@@ -26,6 +26,7 @@ SUPPORTED_OS = { | |||
"centos8-bento" => {box: "bento/centos-8", user: "vagrant"}, | |||
"almalinux8" => {box: "almalinux/8", user: "vagrant"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we replace alma8 completely, wdyt ?
/lgtm |
What type of PR is this?
What this PR does / why we need it:
Kubernetes needs a higher kernel version.
Update CI test from AlmaLinux8 to AlmaLinux9, and keep a few of the AlmaLinux8
Which issue(s) this PR fixes:
Fixes #11888
Special notes for your reviewer:
Does this PR introduce a user-facing change?: