Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update k8s libraries #405

Merged
merged 9 commits into from
Sep 26, 2024
Merged

chore: update k8s libraries #405

merged 9 commits into from
Sep 26, 2024

Conversation

mclarke47
Copy link
Contributor

@mclarke47 mclarke47 commented Sep 24, 2024 •
edited
Loading

What this PR does / why we need it:

  • Update kubernetes dependencies so that we can continue to use the declarative pattern with the latest kubernetes libraries

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

@mclarke47
chore: update k8s libraries
f71e4d3 
Signed-off-by: Matthew Clarke <[email protected]>
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 24, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @mclarke47!

It looks like this is your first PR to kubernetes-sigs/kubebuilder-declarative-pattern 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder-declarative-pattern has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mclarke47. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 24, 2024
@justinsb
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2024
@mclarke47
fix: go mod fmt
8114806 
Signed-off-by: Matthew Clarke <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 24, 2024
@mclarke47
fix: recreate golden testdata
40648dd 
Signed-off-by: Matthew Clarke <[email protected]>
@mclarke47
style: fmt
dd5900e 
Signed-off-by: Matthew Clarke <[email protected]>
@mclarke47
Copy link
Contributor Author

mclarke47 commented Sep 24, 2024 •
edited
Loading

Hey @justinsb it seems like metrics tests are now failing, I'm not totally sure why. Got any pointers?

mclarke47
mclarke47 commented Sep 24, 2024
View reviewed changes
pkg/test/testreconciler/simpletest/controller.go
@@ -90,13 +91,13 @@ func (r *SimpleTestReconciler) SetupWithManager(mgr ctrl.Manager) error {
return err
}

c, err := controller.New("simpletest-controller", mgr, controller.Options{Reconciler: r})
c, err := controller.New(fmt.Sprintf("simpletest-controller-%s", r.TestSuffix), mgr, controller.Options{Reconciler: r})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests started failing due to multiple reconcilers with the same name

@mclarke47
fix: remove comments
e177199 
Signed-off-by: Matthew Clarke <[email protected]>
@mclarke47
fix: remove comment
fa912d1 
Signed-off-by: Matthew Clarke <[email protected]>
@mclarke47
fix: hook up metrics with typed handler
c0d2ea6 
Signed-off-by: Matthew Clarke <[email protected]>
@mclarke47
fix: missed change
f659a97 
Signed-off-by: Matthew Clarke <[email protected]>
@mclarke47
Copy link
Contributor Author

Managed to fix the tests waiting for review 🙏

@mclarke47
fix: PR feedback
a693f72 
Signed-off-by: Matthew Clarke <[email protected]>
tomasaschan
tomasaschan approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@tomasaschan tomasaschan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mclarke47, tomasaschan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit cf8082c into kubernetes-sigs:master Sep 26, 2024
3 checks passed
@mclarke47 mclarke47 deleted the bump-dependencies branch September 26, 2024 14:47
@tomasaschan tomasaschan mentioned this pull request Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasaschan tomasaschan tomasaschan approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@tomasaschan tomasaschan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mclarke47 @k8s-ci-robot @justinsb @tomasaschan