-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update java-spdx to 1.1.8 #437
Conversation
looks like the new licenses broke the validation
cc @puerco |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Ah, didn't see the comment |
I brought this issue to SPDX. The license list version format is baked into the SPDX spec, I think we will need to double tag the license list release for any automation to work with SPDX 2.x documents. I will raise it in the community meeting. |
/hold |
The license list was updated in kubernetes-sigs/release-utils@9c49082 as part of the fix in #462, I think we can keep the spdx tools bump in this PR. |
Signed-off-by: cpanato <[email protected]>
PTAL @puerco |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
/assign @puerco @saschagrunert @xmudrii
cc @kubernetes-sigs/release-engineering
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?