Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update java-spdx to 1.1.8 #437

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 27, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

update license data to v3.24.0

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 27, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2024
@cpanato
Copy link
Member Author

cpanato commented May 27, 2024

looks like the new licenses broke the validation

This SPDX Document is not valid due to:
        License list version does not match the pattern M.N

cc @puerco

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@xmudrii
Copy link
Member

xmudrii commented May 27, 2024

Ah, didn't see the comment
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@puerco
Copy link
Member

puerco commented May 27, 2024

I brought this issue to SPDX. The license list version format is baked into the SPDX spec, I think we will need to double tag the license list release for any automation to work with SPDX 2.x documents. I will raise it in the community meeting.

@cpanato
Copy link
Member Author

cpanato commented May 28, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@puerco
Copy link
Member

puerco commented Jul 27, 2024

The license list was updated in kubernetes-sigs/release-utils@9c49082 as part of the fix in #462, I think we can keep the spdx tools bump in this PR.

@cpanato cpanato changed the title update license data to v3.24.0 update java-spdx to 1.1.8 Jul 29, 2024
@cpanato
Copy link
Member Author

cpanato commented Jul 29, 2024

PTAL @puerco

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Jul 29, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2fa7ecf into kubernetes-sigs:main Jul 29, 2024
7 checks passed
@cpanato cpanato deleted the update-lic branch July 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants