Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated golang version to 1.23.0 #684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated golang version to 1.23.0 #684

wants to merge 1 commit into from

Conversation

cheftako
Copy link
Contributor

@cheftako cheftako commented Jan 8, 2025

go mod edit -go 1.23.0
go mod vendor
make clean
make certs
make gen
make build

@cheftako cheftako requested a review from jkh52 January 8, 2025 00:01
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from elmiko and ipochi January 8, 2025 00:01
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 8, 2025
@cheftako
Copy link
Contributor Author

cheftako commented Jan 8, 2025

/retest

@cheftako cheftako force-pushed the master branch 2 times, most recently from a2b4bdc to e8fbe19 Compare January 8, 2025 23:03
@cheftako
Copy link
Contributor Author

cheftako commented Jan 8, 2025

/test pull-apiserver-network-proxy-test-master

@cheftako
Updated golang version
c9a0e65 
go mod edit -go 1.23.0
go mod vendor
make clean
make certs
make gen
make build

Fixed case of as to match FROM.
Switch go version to 1.23 consistently.
Finished switch from uber/mock to golang/mock.
Updating to lint 1.60.1, which is needed for golang 1.23
@cheftako
Copy link
Contributor Author

cheftako commented Jan 9, 2025

/test pull-apiserver-network-proxy-test-master

2 similar comments
@cheftako
Copy link
Contributor Author

cheftako commented Jan 9, 2025

/test pull-apiserver-network-proxy-test-master

@cheftako
Copy link
Contributor Author

cheftako commented Jan 9, 2025

/test pull-apiserver-network-proxy-test-master

@k8s-ci-robot
Copy link
Contributor

@cheftako: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-apiserver-network-proxy-test-master c9a0e65 link true /test pull-apiserver-network-proxy-test-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tallclair
Copy link
Contributor

/lgtm

Test failures are a bit concerning though

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkh52 jkh52 Awaiting requested review from jkh52

@elmiko elmiko Awaiting requested review from elmiko

@ipochi ipochi Awaiting requested review from ipochi

Assignees

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheftako @k8s-ci-robot @tallclair