Allows to use Maturin with UV #290
Open
+154
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
force-pushed
the
tpt/maturin-uv
branch
4 times, most recently
from
a9f79c6 to
c704bfc
Compare
Tpt
changed the title
Tpt
force-pushed
the
tpt/maturin-uv
branch
6 times, most recently
from
fe1ba70 to
04edf8f
Compare
vsiles
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
@NiklasRosenstein in case you're around sometimes, this would be a really nice to have to start migrating some projects to uv ;)
NiklasRosenstein
approved these changes
Jan 17, 2025
| else: | ||
| from .maturin import MaturinUvPythonBuildSystem | ||
|
|
||
| if "[tool.uv]" not in pyproject_content: |
There was a problem hiding this comment.
Suggested change
| if "[tool.uv]" not in pyproject_content: | |
| if "[tool.uv" not in pyproject_content: |
Just like the checks for poetry/pdm?
| "Got no hint as to the Python dependency system used in the project '%s', falling back to UV (experimental)", | ||
| project_directory, | ||
| ) | ||
| return MaturinUvPythonBuildSystem(project_directory) | ||
|
|
||
| if "pdm" in pyproject_content: | ||
| from .pdm import PDMPythonBuildSystem | ||
|
|
||
| return PDMPythonBuildSystem(project_directory) | ||
|
|
||
| if "[tool.uv]" not in pyproject_content: |
There was a problem hiding this comment.
Suggested change
| if "[tool.uv]" not in pyproject_content: | |
| if "[tool.uv" not in pyproject_content: |
For consistency with the above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.