Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room Booking Update #78

Merged
merged 16 commits into from
Aug 27, 2023
Merged

Room Booking Update #78

merged 16 commits into from
Aug 27, 2023

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Aug 21, 2023

Closes #74

Notes:

  • Read .github/CONTRIBUTING.md before creating the Pull Request. This is a MUST.
  • KOSS Documentation is public. Make sure you are not adding any information which should remain private.

Write path(s) which will be affected by this Pull Request.
Example:

  • /community/governance
  • /events/index
  • /new-section/new-article

Justify your changes or addition.

Why do you think it should be documented?

Will sharing this with just the current members serve our purpose? For example, how you plan to conduct an event next week is a private affair. But, how you generally do the event, should be documented.

@harshkhandeparkar harshkhandeparkar marked this pull request as draft August 21, 2023 14:37
@harshkhandeparkar harshkhandeparkar marked this pull request as ready for review August 25, 2023 17:11
events/room-booking.md Show resolved Hide resolved
events/room-booking.md Outdated Show resolved Hide resolved
events/room-booking.md Outdated Show resolved Hide resolved
events/room-booking.md Outdated Show resolved Hide resolved
events/room-booking.md Outdated Show resolved Hide resolved
events/room-booking.md Outdated Show resolved Hide resolved
Copy link

@rohan-b-84 rohan-b-84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

community/event-checklist.md Show resolved Hide resolved
events/room-booking.md Outdated Show resolved Hide resolved
events/room-booking.md Outdated Show resolved Hide resolved
events/room-booking.md Outdated Show resolved Hide resolved
community/event-checklist.md Show resolved Hide resolved
Copy link
Member

@proffapt proffapt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the stuff looks good.
One thing I would like to add more is to mention that we don't have to pay during CDC if the room is approved by CDC, ig it is important detail to mention

proffapt
proffapt previously approved these changes Aug 27, 2023
Copy link
Member

@proffapt proffapt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@proffapt
Copy link
Member

merge kardu?

@harshkhandeparkar
Copy link
Member Author

merge kardu?

kardo

@harshkhandeparkar
Copy link
Member Author

unless @rohan-b-84 wants to review

@proffapt proffapt merged commit ceba34f into master Aug 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the room-booking-updat branch August 27, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Room Booking Guidelines
3 participants