Configure pipeline-migration-tool run for tekton manager #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkdchen
requested review from
gnaponie,
qixiang,
staticf0x,
FernandesMF,
nvtnlucie and
querti
as code owners
gnaponie
reviewed
Jan 9, 2025
|
Gotcha. So I'm fine with this as change as it is +1 |
FernandesMF
previously approved these changes
Jan 10, 2025
|
/retest re-trigger the test to check if the old buildah task can pass EC checks. |
staticf0x
requested changes
Jan 14, 2025
config/renovate/renovate.json
Outdated
| @@ -310,7 +316,8 @@ | |||
| }, | |||
| "forkProcessing": "enabled", | |||
| "allowedPostUpgradeCommands": [ | |||
| "^rpm-lockfile-prototype rpms.in.yaml$" | |||
| "^rpm-lockfile-prototype rpms.in.yaml$", | |||
| "^pipeline-migration-tool .+" | |||
There was a problem hiding this comment.
Does this have to include the .+ pattern? This allows for arbitrary code execution. One can run pipeline-migration-tool --some-valid arguments && rm -rf * or anything else.
FernandesMF
dismissed
their stale review
The point that Riley brought up is very important.
STONEBLD-2824 Executable script pipeline-migration-tool is available from the Mintmaker image.
tkdchen
force-pushed
the
STONEBLD-2824-configure-pmt
branch
from
8c43a26 to
9ea6c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STONEBLD-2824
Executable script pipeline-migration-tool is available from the Mintmaker image.
This change works with konflux-ci/mintmaker-renovate-image#85 together.