Pipelinerun controller (draft, don't merge!) #114
Conversation
ref: CWFHEALTH-3293 Signed-off-by: Giulia Naponiello <[email protected]>
qixiang
force-pushed
the
refactoring-pipelinerun
branch
from
1231021 to
a8749f6
Compare
Update DependencyUpdateCheck instead of patching
| if req.Namespace != MintMakerNamespaceName { | ||
| return ctrl.Result{}, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
We can ignore PipelineRun updates that not related to status change, when a PipelineRun has status change to error, failed or succeed, but not sure which is the best approach to detect that, maybe status.completionTime?
| var _ = Describe("Pod Controller", func() { | ||
| Context("When reconciling a resource", func() { | ||
|
|
||
| It("should successfully reconcile the resource", func() { |
There was a problem hiding this comment.
We can keep this for a second time, but let's also write some tests. I think it will be sufficient to test that when a PipelineRun finishes a new one starts.
| @@ -0,0 +1,16 @@ | |||
| apiVersion: tekton.dev/v1beta1 | |||
There was a problem hiding this comment.
Probably this file doesn't need to be pushed. If needed we can create a directory such as utils (maybe with a better name) and we can include some useful files there.
|
I've also added only minor comments, the change overall looks good! I've checked only the pipelinerun controller, as I'm assuming the rest is from previous commits. But as Qixiang said, let's rebase the branch, also because my changes were merged, so now they are more correct. |
ref: CWFHEALTH-3293 Signed-off-by: Giulia Naponiello <[email protected]>
Signed-off-by: Giulia Naponiello <[email protected]>
FernandesMF
force-pushed
the
pipelinerun_controller
branch
from
25fba72 to
74b0cae
Compare
|
@gnaponie @qixiang thank you for your reviews, I really appreciate them! |
qixiang
force-pushed
the
refactoring-pipelinerun
branch
from
e3b71bd to
d42eb96
Compare
qixiang
force-pushed
the
refactoring-pipelinerun
branch
from
fa468a4 to
0587273
Compare
Hi team, I finished a first draft of the new PipelineRun controller.
This controller has the responsibility of checking how many pipelineruns are running at the moment, and if there are fewer than a specified value, kick new pipelineruns until the maximum is reached.
Could you please review the code and give your suggestions? Thanks! 😁