Use Django default file mode-settings for uploaded files, and limit use of system() #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k when saving files
… file permissions and owner. Only change one file at the time instead of recursive change, due to that directory permissions and file permissions usually don't mix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits make the following changes:
FILE_UPLOAD_PERMISSIONSandFILE_UPLOAD_DIRECTORY_PERMISSIONSas fallback to determinate new file- and directory modes. This also makes sure to use correct permissions for all created subdirectories.shutil.chown()andos.chmod()instead of spawning separate shell command to recursively change file permissionsThe
shutil.chown()andos.chmod()also fixes an issue where the previous recursive command may set incompatible permissions on any subdirectories for the path (e.g. no +x-permissions)In case you would want me to split the pull request, using
settings.FILE_UPLOAD_PERMISSIONSwill need separate handling to not overwrite directory permissions due to the recursive flag in the system-command.