[DROOLS-7639] ansible-rulebook : support event path for collecting el… #124
Conversation
…ements in array in array - WIP: test case only
| { | ||
| "SelectAttrExpression":{ | ||
| "lhs":{ | ||
| "Event":"incident.alerts.tags" |
There was a problem hiding this comment.
At the moment, this rule doesn't match because "Event":"incident.alerts.tags" doesn't treat alerts as an array. If we change it to "Event":"incident.alerts[1].tags", the rule would match.
| private Object collectPathsForAllElementsInArray(IdentifierNode n) { | ||
| // if accessing a list without an index, evaluate all elements and collect matching children | ||
| List<?> theList = (List<?>) cur; | ||
| List<Object> nextNodeList = new PathWrapperList(); |
There was a problem hiding this comment.
When a visitor faces array access without brackets (e.g. alerts), I introduce PathWrapperList to broaden the search paths. I haven't yet tested a case where PathWrapperList is nested (probably I need to strip it).
| import org.drools.ansible.rulebook.integration.protoextractor.ast.SquaredAccessorNode; | ||
| import org.kie.api.prototype.Prototype; | ||
|
|
||
| public class ValueCollectVisitor extends DefaultedVisitor<Object> { |
There was a problem hiding this comment.
I introduced ValueCollectVisitor and simply replaced with ValueExtractionVisitor. But probably we will need to switch them depending on operator used in a rule condition.
There was a problem hiding this comment.
If I understand correctly the ValueCollectVisitor is a features superset of the ValueExtractionVisitor and as such probably we don't need the second anymore. Also I believe it will be hard if not impossible to discover when the second is enough or it is necessary to use the first. If all I wrote is correct maybe we can totally drop the ValueExtractionVisitor, but let's keep it for now.
There was a problem hiding this comment.
Thanks. Yes, I thought that ValueCollectVisitor could diverge from ValueExtractionVisitor, but it seems to be a superset now. We would be able to drop ValueExtractionVisitor in the near future, but let's keep it for now because Madhu's request may not be finalized yet.
...ebook-integration-api/src/main/java/org/drools/ansible/rulebook/integration/api/LogUtil.java
Outdated
Show resolved
Hide resolved
...ebook-integration-api/src/main/java/org/drools/ansible/rulebook/integration/api/LogUtil.java
Show resolved
Hide resolved
kiegroup#124) * [DROOLS-7639] ansible-rulebook : support event path for collecting elements in array in array - WIP: test case only * WIP implementation * - improved nested list management * Added more tests * convert Set too
…ements in array in array