forked from tum-vision/lsd_slam
-
Notifications
You must be signed in to change notification settings - Fork 38
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Kevin George
committed
Jan 20, 2018
1 parent
7f040ed
commit c0a0581
Showing
1 changed file
with
3 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0a0581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this require opencv3 or will opencv2 work. Also, does this version work with Catkin
c0a0581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version surely works with catkin and OpenCV 3.3.1. I haven't tested it with OpenCV2 though.
c0a0581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ROS has moved to OpenCV 3.x, which is why I made these changes.
If using with ROS Kinetic and above, I recommend using this AS IS.
If not, I would say avoid this commit.
c0a0581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcschwartzman, I could possibly ask this in person but it is better to keep things logged. Can you attach the dump, please? you can
apt-get
it. This gives you a hadnful of options:http://valgrind.org/docs/manual/manual-core.html (you will probably only need --leak-check=full)
valgrind -v YourExecutable
On a side note:
opencv
(or python module cv) stands for the C API of OpenCV whereasopencv2
orcv2
is the C++ extension and does not specify the version. It is frustrating, but when in doubt docv2.__version__
c0a0581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys, I would appreciate it if we could continue this conversation on a issue so other people can benefit from the debugging. Else this would just be valuable info on a "hard-to-find" commit.
Thank you! :)
c0a0581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies I assumed only issues were dropping to my inbox. @mcschwartzman So can you dump the core dump (:D) to a new issue and refer this commit, please?
c0a0581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3