Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/restart parent #6799

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Feat/restart parent #6799

wants to merge 3 commits into from

Conversation

loicmathieu
Copy link
Member

@loicmathieu loicmathieu commented Jan 16, 2025

This PR allows to restart a parent execution when we change the status of a subflow execution task that fail (which restart the subflow execution).

It was not the case before because a parent execution is notified of subflow execution thanks to the subflow execution storage (a table in JDBC and a store in Kafka) which is deleted when the subflow execution ends. So when a subflow execution restart, there are no more subflow execution inside the storage and the parent is never notified again.

Th implementation was changed so the subflow execution storage is no longer needed, we use the information of the execution trigger to know that we need to notify a parent flow so it can be restarted.

The underlying table is not deleted to avoid potential issues during migration; a follow-up issue will be created so the table will be removed in 0.22.

The PR also introduced some small changes to improve change state and restart:

  • Change state was sometimes referred as changed status, this is now aligned everywhere
  • Restarting due to change state now adds the system.restarted: true system label

This PR introduced a (or hit an existing) race in ForEachItem that must be fixed before we can merge it

@loicmathieu loicmathieu marked this pull request as draft January 16, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

1 participant