fix(ui):Added loading screens instead of no data #6602
+159
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthik73965
force-pushed
the
dashboard-loading-screen
branch
from
49eb626 to
d9f440c
Compare
MilosPaunovic
requested changes
Dec 30, 2024
There was a problem hiding this comment.
This is a good approach, but we'd actually like to have entire cards being replace by loading skeletons from Element Plus. Could you do that change before I review it again @Karthik73965?
|
I had few queries . 1 .Should the entire card, including the name, be replaced with loading skeletons? Will do the changes once clarified ! @MilosPaunovic |
|
Yes, every card separately, and yes, we can do it for the entire dashboard (all cards). |
|
@Karthik73965 Is there any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6469
Instead of showing 0 (zeor's) initially while fetching the data now loading screen are being shown in the dashboard .
video6307831181291294961.mp4