Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamiComi: lower chapter list page size and fix missing tags #7145

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

timschneeb
Copy link
Contributor

@timschneeb timschneeb commented Jan 12, 2025

Fixes some oversights from the initial PR.

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

Closes #7151

@AwkwardPeak7
Copy link
Contributor

does this fix #7151?

@timschneeb
Copy link
Contributor Author

does this fix #7151?

Yes

@xdeiimoss
Copy link

Hello! I've built the new code through android studio to check it out and it works. But there's another issue: the author field is appearing as unknown author

@timschneeb
Copy link
Contributor Author

the author field is appearing as unknown author

Thanks for catching that. It broke when I simplified the code and slipped through.
I've double-checked everything and it's fixed now.

@vetleledaal vetleledaal merged commit 80a4753 into keiyoushi:main Jan 13, 2025
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NamiComi: NullPointerException: null when filtering
4 participants