Explicit cloudflareClient if Cloudflare hosted #6613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #6609, change necessitated by J2K not setting
client
tonetwork.cloudflareClient
.Many moving pieces:
super.client
explicitly were checkedbaseUrl
was hosted on Cloudflare it was changedclient
set‡ tonetwork.cloudflareClient
it was set and bumped† estimate
‡ blogtruyen, mangahub, mmrcms, pizzareader, zeistmanga
Yes, I am aware that changing
super.client
tonetwork.cloudflareClient
has no effect for multisrc extensions. The scope was limited to only target Cloudflare hosted services. Another angle may be revisited in another PR.Has not been tested exhaustively since the code change itself is trivial. Relying on CI for lint issues. Reviewing this PR is probably difficult. Here are some notes I used, I'm not sure if it tells you (the reviewer) anything.
Themes modified and what client is set to (excluding mangahub because client was set in multisrc):
Cloudflare sites were checked with:
Checklist:
extVersionCode
value inbuild.gradle
for individual extensionsoverrideVersionCode
orbaseVersionCode
as needed for all multisrc extensionsisNsfw = true
flag inbuild.gradle
when appropriateid
if a source's name or language were changedweb_hi_res_512.png
when adding a new extension